Debug lammps leo #159
Open
Debug lammps leo #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…around where atom_labels are defined.
…rse_method sec_atom.label.
Collaborator
|
@leojbeck I fixed the ruff errors for you, they had nothing to do with your code, just some new rules from ruff affecting old code |
Collaborator
|
@ladinesa can you identify the source of these errors? I reproduce locally with 1. this branch, 2. this branch rebased to develop...but if I just checkout develop I don't have these errors. And I can't see anything relevant that is changed in this PR 🤔 |
Collaborator
|
The module-level import for MatchingParserInterface broke this, It will lead to cyclic import, pushed fix now. |
* Upgrade ase * Update asap traj files * Linting fix * Update gh action * Use ase 3.22 * Write asap traj in ase==3.25 and skip tests * Fix commit * Add condition to run test * Fix commit --------- Co-authored-by: Alvin Noe Ladines <ladinesalvinnoe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
To Dos: