Polish file browser appearance and add screenshot tests - #44
Open
matchaboar wants to merge 1 commit into
Open
matchaboar wants to merge 1 commit into
matchaboar wants to merge 1 commit into
Conversation
Owner
|
This looks good overall. Before merging, please rebase onto current main and resolve the conflicts, keeping the v3.2 tab reordering and heading spine changes intact. This and #45 both introduce FileBrowserView.swift, so we also need to line up those changes so neither gets lost. The Swift sources pass type-checking locally, but there are no CI results on this PR yet. Please get the build, logic tests, and screenshot checks passing on the rebased commit, and give the title-bar double-click behavior a quick manual check. Once that's done, I'm happy to take another look for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focused UI appearance and screenshot-testing split from #43, rebased onto current
main.CI permissions
Tests now run in a separate
testsjob withpermissions: contents: readandactions/checkoutconfigured withpersist-credentials: false. The release/build job remains separate and no longer executes tests. Its checkout also disables persisted credentials; the appcast push receives an explicit token only in the tag-only step that needs it.Red/green and screenshot runs
Environment: macOS 26.6.1 arm64, Swift 6.3.1.
./run-screenshot-tests.sh./run-screenshot-tests.sh --record./run-screenshot-tests.sh./run-screenshot-tests.sh./run-screenshot-tests.sh./run-tests.sh./run-tests.sh./build.shThe populated light/dark baselines cover the folder header, refresh control, expanded hierarchy, and active-file treatment. Empty and error baselines cover the remaining sidebar states. These are screenshot/correctness results, not performance claims.