Repository navigation
feat: ship an Acme theme and keep light palettes off the terminal background - #19
Merged
Merged
Conversation
…kground Gutter padding, M-x/swiper rows, and reverse video were resetting to the terminal's colors, which punched black holes in any light theme. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:acmepalette from Plan 9draw.h/acme.c(pale yellow body, cyan tag, dark-yellow selection).reset, and the selected candidate is a:candidate-selface (falls back to:region) instead of reverse video.Test plan
M-x load-themeacmeon a dark terminal: yellow body, cyan mode line, no black stripe beside line numbersM-xandC-sunder Acme (and Latte): candidate list uses the editor background; the current row is a themed highlight, not a khaki inverse barlg -e "(require '[test :refer [run-tests]] '[test.theme-test] '[test.render-test]) (run-tests)"Made with Cursor