Repository navigation
fix: keep scratch eval working after ns forms, vibe, and go/future - #20
Merged
Merged
Conversation
C-c C-e restored the editor ns so C-x C-e missed buffer-local defs, vibe vanished after (ns ...), and a scratch (go ...) parked the loop on read-key while println wrote onto the TTY. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(ns …)and restore the editor ns afterwards, so C-c C-e then@aseesfoo/ainstead of compiling inlegmacs.main.vibeintolet-go.coreso(ns weather)does not make C-c C-v fail with "Can't resolve vibe".go/futurespawns and capture*out*/*err*during eval so a background goroutine cannot freeze the UI or paint over the TTY.Test plan
lg test/run.lg*scratch*:(ns foo)/(def a (atom 0))via C-c C-e, then C-x C-e on@aprints=> 0(not "Can't resolve a")(ns weather)then C-c C-v on(vibe "…")resolvesvibe(future (sleep 5000))returns immediately; editor still takes keys(go (println "hi"))does not clobber the frame; typing still worksMade with Cursor