Repository navigation
Conversation
r-web truncated (/ ddx len) with int. For an off-axis target the division makes a Ratio first, e.g. (/ 1 3) is 1/3 before int turns it into 0. quot gives the same truncated Int without the Ratio, which is what the "normalize to -1/0/1" comment meant all along, and it no longer depends on the runtime having a Ratio type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r-webturns the caster-to-target offset into a -1/0/1 step with(int (/ ddx len)). For an off-axis target,/on two Ints returns a Ratio ((/ 1 3)is1/3), whichintthen truncates to 0.quotreturns the same Int without the intermediate Ratio.Behavior is unchanged. For offsets (1,3), (-2,3), (4,0), (0,0), and (-5,-5), the old and new forms both return
[0 1],[0 1],[1 0],[0 0], and[-1 -1], and the test suite passes on lg v1.13.0 (the pin).This came up running xsofy on a let-go runtime without a Ratio type, where the division raised and Web crashed when cast off-axis.
r-pushdivides by the Float frommath/sqrt, so it never makes a Ratio and stays as is.🤖 Generated with Claude Code