Fix IB bid/ask sentinel value handling#4
Merged
Conversation
IB's TWS/Gateway returns -1.0 for bid/ask when market data is unavailable. Added filtering to treat -1.0 as a "no data" sentinel, converting it to None. This allows the fallback logic to correctly retry with delayed data when live quotes are unavailable. Also enhanced test fixture to support custom bid/ask values. Co-Authored-By: Bryce Bjork <brycedbjork@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IB's TWS/Gateway returns -1.0 for bid/ask when market data is unavailable (e.g., market closed or no data subscription). The daemon was passing these through as valid prices instead of filtering them as sentinel values.
This fix adds filtering for -1.0 in the
_to_float_or_none()function, treating it as "no data" and converting it to None. This allows the existing fallback logic to correctly retry with delayed market data when live quotes contain sentinel values.The test fixture was also enhanced to support custom bid/ask values for future test scenarios.
Co-Authored-By: Bryce Bjork brycedbjork@gmail.com