Skip to content

syncv2: add encrypted to USBMountEvent#102

Merged
sharvilshah merged 1 commit intomainfrom
sbs/ws-1092-add-encrypted-to-usb-event
Mar 20, 2026
Merged

syncv2: add encrypted to USBMountEvent#102
sharvilshah merged 1 commit intomainfrom
sbs/ws-1092-add-encrypted-to-usb-event

Conversation

@sharvilshah
Copy link
Copy Markdown
Contributor

Part of WS-1092

@sharvilshah sharvilshah requested a review from a team as a code owner March 20, 2026 15:41
@github-actions
Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow .github/workflows/update.yml / generate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed⏩ skipped✅ passedMar 20, 2026, 3:41 PM

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5de17740-e136-4233-94b2-3633942bb3a2

📥 Commits

Reviewing files that changed from the base of the PR and between 8596598 and 782b448.

📒 Files selected for processing (1)
  • syncv2/v2.proto

📝 Walkthrough

Walkthrough

A new optional boolean field encrypted is added to the USBMountEvent message in the protobuf schema at field number 9 with corresponding JSON name mapping.

Changes

Cohort / File(s) Summary
Protobuf Schema Update
syncv2/v2.proto
Added optional boolean field encrypted (field 9) to USBMountEvent message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #79: Extends USBMountEvent protobuf message with additional optional boolean field modifications
  • PR #80: Modifies USBMountEvent by adding access_time field to the same message
  • PR #83: Modifies USBMountEvent by adding remount_flags and decision fields, with the new encrypted field positioned immediately after the decision field
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding an 'encrypted' field to the USBMountEvent message in the syncv2 proto file.
Description check ✅ Passed The description references the related work item (WS-1092) and is directly relevant to the changeset, though minimal in detail.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sbs/ws-1092-add-encrypted-to-usb-event

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting to disable sequence diagrams in the walkthrough.

@sharvilshah sharvilshah merged commit c961c48 into main Mar 20, 2026
3 checks passed
@sharvilshah sharvilshah deleted the sbs/ws-1092-add-encrypted-to-usb-event branch March 20, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants