Conversation
|
The latest Buf updates on your PR. Results from workflow .github/workflows/update.yml / generate (pull_request).
|
|
Buf breaking is expected and okay - these fields have not been shipped yet. |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughField types for rule_id were changed from uint64 to int64 in four protobuf message definitions within syncv2/v2.proto. No field numbers, names, or additional structures were altered. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Since sqlite can't store uint64 as a col type natively, let's match what it can store so we don't have to do any casting.