Skip to content

use int64 type for rule_id#105

Merged
tburgin merged 1 commit intomainfrom
bur/signed
Mar 26, 2026
Merged

use int64 type for rule_id#105
tburgin merged 1 commit intomainfrom
bur/signed

Conversation

@tburgin
Copy link
Copy Markdown
Contributor

@tburgin tburgin commented Mar 26, 2026

Since sqlite can't store uint64 as a col type natively, let's match what it can store so we don't have to do any casting.

@tburgin tburgin requested a review from a team as a code owner March 26, 2026 14:48
@github-actions
Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow .github/workflows/update.yml / generate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed⏩ skipped❌ failed (4)Mar 26, 2026, 2:48 PM

@tburgin
Copy link
Copy Markdown
Contributor Author

tburgin commented Mar 26, 2026

Buf breaking is expected and okay - these fields have not been shipped yet.

@tburgin tburgin enabled auto-merge (squash) March 26, 2026 14:48
@russellhancox russellhancox added the buf skip breaking Skip Buf's breaking changes check label Mar 26, 2026
@tburgin tburgin merged commit 96ef1e3 into main Mar 26, 2026
1 of 3 checks passed
@tburgin tburgin deleted the bur/signed branch March 26, 2026 14:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1527ecd6-7cfe-4ebf-aade-c0da524f986f

📥 Commits

Reviewing files that changed from the base of the PR and between 68c1b8f and 253a722.

📒 Files selected for processing (1)
  • syncv2/v2.proto

📝 Walkthrough

Walkthrough

Field types for rule_id were changed from uint64 to int64 in four protobuf message definitions within syncv2/v2.proto. No field numbers, names, or additional structures were altered.

Changes

Cohort / File(s) Summary
Proto field type updates
syncv2/v2.proto
Changed rule_id type from uint64 to int64 in messages: Event (field 35), FileAccessEvent (field 7), Rule (field 10), FileAccessRule.Add (field 13).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: converting rule_id field types from uint64 to int64 across multiple protobuf messages.
Description check ✅ Passed The description is directly related to the changeset, providing clear rationale: SQLite compatibility by matching native column types to avoid casting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bur/signed

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buf skip breaking Skip Buf's breaking changes check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants