[WIP] telemetry: record oflags for FileAccess events#804
Draft
sharvilshah wants to merge 2 commits intomainfrom
Draft
[WIP] telemetry: record oflags for FileAccess events#804sharvilshah wants to merge 2 commits intomainfrom
FileAccess events#804sharvilshah wants to merge 2 commits intomainfrom
Conversation
github-actions
bot
added
comp/santad
…ts-when-appropriate
grimley517
reviewed
Apr 13, 2026
| optional string operation_id = 7; | ||
|
|
||
| // The access mode of the file in question | ||
| enum AccessMode { |
There was a problem hiding this comment.
have you considered using a flagged enum for this?
eg
[flags]
enum
{
CanRead= 0b0001
CanWrite= 0b0010
}
This gives all 4 access modes in a similar manner to unix. and prevents people having to check for read and write separately.
grimley517
reviewed
Apr 13, 2026
grimley517
left a comment
grimley517
left a comment
There was a problem hiding this comment.
access mode - suggest using flags to identify capabilities rarther than the logical modes. the enum is MECE, but this makes what you do with the mode more complicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still testing and updating