Repository navigation
sdk: report receiver-local notification gaps - #1482
Closed
erskingardner wants to merge 2 commits into
Closed
erskingardner wants to merge 2 commits into
erskingardner wants to merge 2 commits into
Conversation
Add parallel client and relay notification streams that expose broadcast lag without changing existing notification enum variants. Keep receiver-local gap counts distinct from event coverage and preserve reception after a gap. Cover paused and active loopback receivers, repeated overflow, closure, and shutdown. Document the legacy behavior and add a minimal consumer example.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yukibtc
added a commit
that referenced
this pull request
Oct 1, 2026
Introduce optional gap reporting in `NotificationStream`, allowing users to observe skipped notifications using `NotificationStream::with_gaps()` method. Replaces #1482 Co-authored-by: Jeff Gardner <202880+erskingardner@users.noreply.github.com> Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
yukibtc
added a commit
that referenced
this pull request
Oct 1, 2026
Introduce optional gap reporting in `NotificationStream`, allowing users to observe skipped notifications using `NotificationStream::with_gaps()` method. Replaces #1482 Co-authored-by: Jeff Gardner <202880+erskingardner@users.noreply.github.com> Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
3 tasks done
Preserve fast-receiver lag and closure assertions while exercising unrelated EOSE handling. Remove redundant failure-only match arms that inflated the patch coverage miss count.
Member
|
Replaced by #1489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification streams currently skip broadcast lag silently, so a caller can continue receiving notifications without knowing its receiver missed some.
Add
Client::notifications_with_gaps()andRelay::notifications_with_gaps(), returningNotificationUpdateitems that distinguish a notification from receiver-local lag. Reception continues after a gap; the skipped count counts notifications, not unique events or missing subscription inventory. Existing notification APIs and enum variants keep their behavior.Includes API documentation, changelog, a consumer example, and tests covering repeated overflow, independent fast/slow client and relay receivers, continued reception, shutdown/ban, creation after termination, dropping a receiver, and legacy stream behavior.
Validation:
just precommit; stable workspace Clippy with all targets and warnings denied; stable all-feature SDK tests.