Repository navigation
sdk: retain partial reconciliation progress with relay outcomes - #1483
Merged
yukibtc merged 1 commit intoOct 12, 2026
Merged
Conversation
Add an opt-in relay outcome API and retain failed-relay progress in aggregate summaries while preserving direct sync error behavior. Exercise partial batch rejection, success, preflight failures, cleanup, and healthy/failing relay aggregation.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Anything you'd like changed here @yukibtc ? |
yukibtc
approved these changes
Oct 12, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reconciliation downloads a batch and then fails, its returned error currently discards the summary. Aggregate reconciliation also loses that failed relay's progress even when another relay succeeds.
Add
SyncEvents::with_outcomes()andRelaySyncOutcometo return observed progress alongside the terminal error. Aggregate client reconciliation retains failed-relay progress while keeping the relay inOutput::failed. Directsync().awaitpreserves its existing success/error behavior; preflight failures still returnErr.Builds on the reconciliation cleanup and download-rejection handling integrated from #1480, retaining upstream's refined implementation. Observed progress does not imply completed reconciliation or downstream durable admission.
Tests exercise success, preflight/read-capability failures, first/later rejected download batches, request cleanup, and an aggregate run where a healthy relay completes while a failing relay retains its first 100 downloads.
Validation:
just precommit; stable workspace Clippy with all targets and warnings denied; stable all-feature SDK tests.