Repository navigation
sdk: rework relay connection task handling - #1491
Merged
Merged
Conversation
yukibtc
added a commit
that referenced
this pull request
Oct 7, 2026
Keep one task per relay and retain connection requests while an old WebSocket closes. Share connection outcomes between `Relay::try_connect` callers and stop the task on ban, shutdown or the last Relay drop. Replaces #1479 Pull-Request: #1491 Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
yukibtc
force-pushed
the
sdk-rework-relay-task
branch
from
October 7, 2026 09:50
3c5e0c9 to
b5afc69
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
yukibtc
force-pushed
the
sdk-rework-relay-task
branch
from
October 12, 2026 10:56
b5afc69 to
31a0237
Compare
yukibtc
added a commit
that referenced
this pull request
Oct 12, 2026
Keep one task per relay and retain connection requests while an old WebSocket closes. Share connection outcomes between `Relay::try_connect` callers and stop the task on ban, shutdown or the last Relay drop. Replaces #1479 Pull-Request: #1491 Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
3 tasks done
Keep one task per relay and retain connection requests while an old WebSocket closes. Share connection outcomes between `Relay::try_connect` callers and stop the task on ban, shutdown or the last Relay drop. Replaces #1479 Pull-Request: #1491 Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
yukibtc
force-pushed
the
sdk-rework-relay-task
branch
from
October 13, 2026 13:27
31a0237 to
c28142e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rework the relay connection task handling, and fix the issues raised at #1479
Replaces #1479
Notes to the reviewers
This is a bit larger PR compared to #1479, but includes a complete refactor of the connection task handling, which now should be clearer and more robust.
Checklist
CHANGELOG.md(if applicable)