Skip to content

Conversation

@qba73
Copy link
Contributor

@qba73 qba73 commented Apr 18, 2025

This PR:

Signed-off-by: Jakub Jarosz <jakub@jarosz.dev>
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.47%. Comparing base (6063ebe) to head (1866537).

Files with missing lines Patch % Lines
verifier/verifier.go 42.85% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (42.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files          36       36           
  Lines        3358     3358           
=======================================
  Hits         2736     2736           
  Misses        480      480           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Apr 24, 2025

@qba73 Looks like the test coverage is below the patch target. Please see the Codecov report for details: #537 (comment)

@ghost ghost changed the title fix staticcheck issues in the verifier pkg fix: fix staticcheck issues in the verifier pkg Apr 27, 2025
@github-actions
Copy link

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jun 27, 2025
@github-actions github-actions bot removed the Stale label Jul 3, 2025
@qba73 qba73 closed this Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant