Conversation
0xpr03
reviewed
May 7, 2024
Member
0xpr03
left a comment
0xpr03
left a comment
There was a problem hiding this comment.
I think we will need way more documentation to keep this usable in the future
notify-debouncer-full/src/lib.rs
Outdated
|
|
||
| events_expired.push(event); | ||
| } else { | ||
| self.queues.get_mut(&path).unwrap().events.push_front(event); |
Member
There was a problem hiding this comment.
same here for unwrap stuff - want to avoid crashing and rather report an error
dfaust
force-pushed
the
fix-blender-save
branch
from
b110f0e to
3fb1c37
Compare
Member
Author
Agreed. I will add more comments as I work on it. |
Member
|
We can merge this for now, if you want. I just would like to document this, because I fear we will otherwise have a ton of regressions in the future. |
Member
Author
|
Then let's not merge it for now. I will document it better and try to fix the original issue. While the PR does improve the behavior of the debouncer, it doesn't actually fix the blender issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debouncer is getting increasingly complicated. It took me a few tries to design this change as defensively as possible. I hope it doesn't break anything.
This PR is based on #569.