Open
Conversation
Replace hardcoded memory management text with interactive memory overlay using TypeaheadOverlay component. Users can now navigate memory options with arrow keys and select actions through a consistent UI. Changes: - Add MemoryOverlay component using TypeaheadOverlay - Add session-memory.ts utility for memory operations - Replace /memory text display with overlay interface - Add memory overlay to terminal-chat overlay system - Update tests to include openMemoryOverlay prop - Add CLI memory commands (codex memory clear/status) The memory interface now matches other overlay UIs in the application and provides better UX for memory management. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GitHub Copilot as an authentication provider. It introduces a new provider configuration, implements a dedicated client for handling GitHub Copilot token retrieval via device flow, and updates the agent loop and CLI to use provider-specific API key handling.
- Added GitHub Copilot provider into the providers record.
- Implemented GithubCopilotClient with device flow token refresh logic.
- Augmented API key retrieval, agent loop, and CLI to support GitHub Copilot.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| codex-cli/src/utils/providers.ts | Adds a new provider entry for GitHub Copilot with provider-specific details. |
| codex-cli/src/utils/openai-client.ts | Introduces GithubCopilotClient and token retrieval via device flow. |
| codex-cli/src/utils/get-api-key.tsx | Implements getGithubCopilotApiKey and integrates a spinner for user prompts. |
| codex-cli/src/utils/agent/agent-loop.ts | Updates agent loop to instantiate the specialized GitHub Copilot client. |
| codex-cli/src/cli.tsx | Adjusts CLI API key handling to support GitHub Copilot login and storage. |
Comments suppressed due to low confidence (2)
codex-cli/src/utils/providers.ts:56
- Consider renaming the provider name to "GitHub Copilot" to maintain consistent branding with GitHub's official naming conventions.
name: "GithubCopilot",
codex-cli/src/utils/openai-client.ts:74
- Update the error message to use "GitHub Copilot" instead of "github copilot" for consistent capitalization in branding.
throw new Errors.OpenAIError("missing github copilot token");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm testpnpm --filter @openai/codex run linthttps://chatgpt.com/codex/tasks/task_e_684ed81f3ea8832688ef4d0cf3ba3ee2