fix: bump CI Node floor to 24, declare package.json engines - #115
Merged
Conversation
Node 20 left maintenance 2026-04-30. Same pin on `vires` made a jsdom 29→30 bump fail with 27 module-load errors plus a 0%-coverage gate failure — a dependency bump reading as a test regression, since jsdom@30 requires node ^22.22.2 || ^24.15.0 || >=26.0.0. - ci.yml: node-version 20 -> "24" (current active LTS) - web/package.json: engines.node ">=24.15.0" so the floor is declared where the package can see it, not only in CI telos-ops-I41 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0195gwKbV5G2zycACkZ5Ru69
cipher813
marked this pull request as draft
September 9, 2026 22:12
cipher813
marked this pull request as ready for review
September 9, 2026 22:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
.github/workflows/ci.yml:75pinnednode-version: 20. Node 20 left maintenance 2026-04-30.Measured cost of the same pin elsewhere:
viresCI on Node 20 madevires-PR195(jsdom 29 → 30) fail with 27 module-load errors (TypeError: webidl.util.markAsUncloneable is not a function) plus four coverage-threshold errors at 0% — a dependency bump that presented as a test regression.jsdom@30declaresnode: ^22.22.2 || ^24.15.0 || >=26.0.0, excluding 23 and 25.Addresses
telos-ops-I41.Changes
.github/workflows/ci.yml:node-version: 20→node-version: "24"(current active LTS)web/package.json: addedengines.node: ">=24.15.0"so the floor is declared where the package can see it, not only in CIRepo has a single Node workflow (
webjob inci.yml) and a singlepackage.json(web/); both are covered.grep -rn 'node-version' .github/workflows/now returns only"24".Test plan (measured locally on Node v26.5.0, satisfying
>=24.15.0).venv/bin/python3 -m pytest tests/ -q→ 483 passed, 1 skippedcd web && npm ci→ clean installnpx tsc --noEmit→ exit 0npx eslint .→ exit 0npm run build(Next.js 16.3.4, Turbopack) → succeeded, static pages generatedPrepared by: Claude Sonnet 5 via Claude Code