feat: replace thoas with Erlang/OTP json module#10
Closed
Conversation
Use json:encode/1 and json:decode/1 directly instead of the configurable json_lib approach via nova:get_env. The json_lib config option was removed from Nova. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update pre_request/post_request to 4-arity callbacks matching the current nova_plugin behaviour. Update plugin_info to return a map instead of a tuple. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing — all changes are included in #11 (RFC 9457 error responses), which builds on top of this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nova:get_env(json_lib, thoas)with directjson:encode/1andjson:decode/1callsRelated: novaframework/nova#366
🤖 Generated with Claude Code