Fix nia add folder persistence and improve upload type errors#35
Draft
arlanrakh wants to merge 2 commits into
Draft
Fix nia add folder persistence and improve upload type errors#35arlanrakh wants to merge 2 commits into
nia add folder persistence and improve upload type errors#35arlanrakh wants to merge 2 commits into
Conversation
Co-authored-by: Arlan Rakhmetzhanov <arlanrakh@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Arlan Rakhmetzhanov <arlanrakh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nia add <target>command that routes by target type:detected_type=folder)nia statuscommand to show configured local sources (same status view as local sources, with explicitNo sources configured.when empty).nia sources upload:.mdand.docxnow return a clear message with supported types and a folder-based workaroundresolveUploadContentType()for reusable validationtests/commands/add.test.ts).Why
User-reported behavior showed folder targets being detected but not persisted when using
nia add, followed bynia statusshowing no configured sources. The new root add path now performs explicit folder registration via the local daemon and surfaces actionable backend error details.Verification
.md/.docxupload messaging includes supported typesd8e843a.Summary by cubic
Adds root
nia addandnia statuscommands. Fixes folder source persistence and clarifies upload errors with actionable guidance.New Features
nia add <target>auto-detects target:nia statuslists configured local sources (shows “No sources configured.” when empty)resolveUploadContentType()and centralized supported types:.pdf,.csv,.xlsxBug Fixes
.md/.docxnow suggest adding the parent folder and list supported typesaddcommandWritten for commit d8e843a. Summary will update on new commits.