This repository was archived by the owner on Aug 11, 2021. It is now read-only.
fix: ability to process package-lock.json with more than 1024*1024 bytes - #21
Open
DudaGod wants to merge 2 commits into
Open
fix: ability to process package-lock.json with more than 1024*1024 bytes#21DudaGod wants to merge 2 commits into
DudaGod wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the case when you have package-lock.json is more than 1048576 (1024 * 1024) bytes child process fails with error here - https://github.com/npm/npm-merge-driver/blob/latest/index.js#L195-L201. Error:
To fix it I increase
maxBuffertoInfinityand add error handler for child process in order to exit if something goes wrong.Environment:
node: 12.18.0
npm: 6.14.5
git: 2.29.1