fix: prevent path duplication in attestation URL for registries with …#452
Open
fix: prevent path duplication in attestation URL for registries with …#452
Conversation
…path components When a custom registry URL includes a path (e.g. https://example.com/javascript), the attestation URL was incorrectly constructed by concatenating the full registry URL with the full pathname from the attestation URL, causing the path to be duplicated (e.g. /javascript/javascript/-/npm/v1/attestations/...). Use the URL constructor to correctly resolve the pathname against the registry origin, matching the existing pattern in lib/remote.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: prevent path duplication in attestation URL for registries with path components
When a custom registry URL includes a path (e.g. https://example.com/javascript),
the attestation URL was incorrectly constructed by concatenating the full registry
URL with the full pathname from the attestation URL, causing the path to be
duplicated (e.g. /javascript/javascript/-/npm/v1/attestations/...).
Use the URL constructor to correctly resolve the pathname against the registry
origin, matching the existing pattern in lib/remote.js.
References
Fixes #450