Skip to content

Comments

fix: blank gap on collapsed weekly downloads#1639

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
RYGRIT:fix/weekly-download-area-blank
Feb 25, 2026
Merged

fix: blank gap on collapsed weekly downloads#1639
danielroe merged 1 commit intonpmx-dev:mainfrom
RYGRIT:fix/weekly-download-area-blank

Conversation

@RYGRIT
Copy link
Contributor

@RYGRIT RYGRIT commented Feb 25, 2026

🔗 Linked issue

Follow-up #1619

🧭 Context

#1619 (review)

📚 Description

before after
image image

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 25, 2026 4:56am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 25, 2026 4:56am
npmx-lunaria Ignored Ignored Feb 25, 2026 4:56am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02ac533 and 1797101.

📒 Files selected for processing (1)
  • app/components/Package/WeeklyDownloadStats.vue

📝 Walkthrough

Walkthrough

This PR modifies the WeeklyDownloadStats.vue component's layout by repositioning height-related utility classes. Specifically, it removes height constraints from the outer container and applies responsive height properties to the outer structure instead. The change affects vertical space allocation during loading and rendering of the sparkline area without altering data flow, state management, or conditional rendering logic.

Possibly related PRs

Suggested reviewers

  • 43081j
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is related to the changeset, referencing a follow-up issue and including before/after screenshots demonstrating the visual fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 25, 2026
Merged via the queue into npmx-dev:main with commit 714ab63 Feb 25, 2026
18 checks passed
@RYGRIT RYGRIT deleted the fix/weekly-download-area-blank branch February 25, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants