implement initial lock format parsing #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrdxp
added a commit
that referenced
this pull request
Dec 23, 2024
instead parse eka produced locks with #42, which builds off of this PR
The evaluation will prefer a local path, if it exists, to make interactive development in repos with more than one atom convenient.
update lock parsing code for latest, evolving lock format
Separate eval time sources (`from`) from build time sources (`get`) for intuitive and clear API surface.
set initial source type to "build" to clarify it is primarily meant for build sources.
Enable pins to source from another atom using a `from` key, avoiding duplicate specs and manual syncing. Support overriding the `path` key as well as using the `get` key to set a different `name` than the downstream pin. Otherwise, it will cook for a pin of the same `name`.
No longer do we import a toml in the same directory as the atom root. In keeping with the spirit of having atoms be truly self-contained, we now parse a generic `atom.toml` file and an `atom.lock` file inside the atom's root directory.
The config should be parsed and passed on the rust side eventually, so there is no reason to maintain complex parsing logic here.
eka's first iteration lock format is now available for testing and we will no longer maintain the locking expression in this repo, as it is coupled to a specific version of eka.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset includes code for evaluating eka produced lock files and injecting them into the atom's scope
Currently in draft as it is still a work in progress, but currently legacy expressions and atom dependencies evaluate successfully, for the most part
TODO
importAtomfunction