fix(vite): widen vite ts-solution e2e build timeouts for cold multi-lib build#36093
Open
FrozenPandaz wants to merge 1 commit into
Open
fix(vite): widen vite ts-solution e2e build timeouts for cold multi-lib build#36093FrozenPandaz wants to merge 1 commit into
FrozenPandaz wants to merge 1 commit into
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit f1937be
☁️ Nx Cloud last updated this comment at |
f1937be to
12b2079
Compare
12b2079 to
c21eb93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
e2e/vite/src/vite-ts-solution.test.ts("should generate app and consume libraries with different bundlers") intermittently fails withCommand timed out after 300s: build react-app....The single
build <app>cold-builds the app's six dependency libraries first (esbuild / rollup / swc / tsc / vite / none) and then the app, serially, in a freshly created TS-solution workspace. Each individual build is sub-second, but the serial total (plus first-run tsc project-reference build, bundler cold starts, and graph computation) can exceed the default 5-minuterunCLItimeout under CI load. The command hit that 300srunCLIcap (separate from the test's own jest timeout).Expected Behavior
The
buildandtypecheckinvocations get a 10-minuterunCLItimeout, and the test's jest timeout is raised to 20 minutes to cover the seven generators + install + sync + build + typecheck end-to-end. CI load no longer tips the cold multi-library build over its budget.Related Issue(s)
N/A — CI flake fix.
View session information ↗