Improve error handling for API specifications - #64
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable workflow that uploads and persists an OpenAPI spec to improve diagnostics when the persist API call fails, by capturing the HTTP response body alongside the status code.
Changes:
- Capture curl response body + status code from the persist endpoint and print the body on failure.
- Adjust status-code handling to be derived from the combined response output.
Changed files:
.github/workflows/helpers.upload-open-api-spec.yml
Validation result: ❌ Error
Issues found:
.github/workflows/helpers.upload-open-api-spec.yml:100-103— Response parsing usesechoand a numeric-necomparison that can fail (e.g., status line containing\r), causing the step to error with “integer expression expected” instead of cleanly reporting the failure..github/workflows/helpers.upload-open-api-spec.yml:91—curl --silentsuppresses useful diagnostics;--show-errorshould be enabled to improve troubleshooting.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
isabelle-galleberg
force-pushed
the
api-references-response
branch
from
August 26, 2026 11:19
74ec3b7 to
e14a157
Compare
Fr3dric0
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.