Skip to content

Use a unique name for API-spec based on application name - #68

Merged
isabelle-galleberg merged 1 commit into
mainfrom
fix/open-api-spec-name
Sep 18, 2026
Merged

isabelle-galleberg merged 1 commit into
mainfrom
fix/open-api-spec-name

Conversation

@isabelle-galleberg

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings September 18, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Artifact names may exceed length limits or contain unsupported characters.

Pull request overview

Updates the reusable OpenAPI workflow to use application-specific artifact names and prevent collisions.

Changes:

  • Includes application-name in upload and download artifact names.
  • Uses the same name consistently across jobs.
File summaries
File Summary
.github/workflows/helpers.upload-open-api-spec.yml Adds unique application-based artifact names; needs bounded and sanitized identifiers for GitHub constraints.
Review details

Suppressed comments (1)

.github/workflows/helpers.upload-open-api-spec.yml:48

  • This makes the reusable workflow fail for otherwise valid application-name values that produce an artifact name longer than GitHub's 64-character limit (the fixed open-api-spec name did not have this constraint); artifact names also reject several characters that were previously accepted by this workflow. Derive a bounded, sanitized artifact identifier (and use the same identifier for download), or validate the input before attempting the upload.
          name: 'open-api-spec-${{ inputs.application-name }}'
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@isabelle-galleberg
isabelle-galleberg merged commit a1c333e into main Sep 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants