Use a unique name for API-spec based on application name - #68
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Artifact names may exceed length limits or contain unsupported characters.
Pull request overview
Updates the reusable OpenAPI workflow to use application-specific artifact names and prevent collisions.
Changes:
- Includes
application-namein upload and download artifact names. - Uses the same name consistently across jobs.
File summaries
| File | Summary |
|---|---|
.github/workflows/helpers.upload-open-api-spec.yml |
Adds unique application-based artifact names; needs bounded and sanitized identifiers for GitHub constraints. |
Review details
Suppressed comments (1)
.github/workflows/helpers.upload-open-api-spec.yml:48
- This makes the reusable workflow fail for otherwise valid
application-namevalues that produce an artifact name longer than GitHub's 64-character limit (the fixedopen-api-specname did not have this constraint); artifact names also reject several characters that were previously accepted by this workflow. Derive a bounded, sanitized artifact identifier (and use the same identifier for download), or validate the input before attempting the upload.
name: 'open-api-spec-${{ inputs.application-name }}'
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.