Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the dorny/test-reporter GitHub Action to the VUnit test workflow to provide enhanced test result reporting capabilities. This addresses issue #27.
Key Changes
- Added a new "Test Report" step using
dorny/test-reporter@v2to process VUnit test results - Configured the action to parse
test-reports/vunit_results.xmlas JUnit XML format - Set the step to run with
!cancelled()condition andfail-on-error: falsesettings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: dorny/test-reporter@c8370352934b730bc7f9acc17180a1f5f3964ffd # v2 | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: VUnit Test Results |
There was a problem hiding this comment.
The name "VUnit Test Results" conflicts with the check_name used in the "Publish Test Results" step at line 78. Having duplicate names can cause confusion in the GitHub UI when viewing checks and test results. Consider using a more specific name like "Test Report Summary" or "Dorny Test Reporter" to differentiate it from the other test reporting mechanisms.
| name: VUnit Test Results | |
| name: VUnit Test Report Summary |
|
|
||
| - name: Test Report | ||
| uses: dorny/test-reporter@c8370352934b730bc7f9acc17180a1f5f3964ffd # v2 | ||
| if: ${{ !cancelled() }} |
There was a problem hiding this comment.
The new "Test Report" step uses a different conditional (if: ${{ !cancelled() }}) compared to the other test reporting steps in the workflow (lines 68, 75, 82) which use if: always(). This inconsistency means this step won't run if the "Run VUnit tests" step fails, while the other test reporting steps will. For consistent test result reporting regardless of test outcome, consider using if: always() instead.
| if: ${{ !cancelled() }} | |
| if: always() |
Fixes #27