Skip to content

feat(plugin-utils): extract data-storage skill into new plugin (from #157) - #215

Merged
nsheaps merged 2 commits into
mainfrom
claude/extract-plugin-utils-data-storage
May 29, 2026
Merged

nsheaps merged 2 commits into
mainfrom
claude/extract-plugin-utils-data-storage

Conversation

@alex-nsheaps

@alex-nsheaps alex-nsheaps Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Extracts the data-storage-using-the-filesystem skill out of the bundled, conflicting PR #157 into a focused, clean PR based on current main.

Per Nate's instruction, the skill lands in a new plugin-utils plugin (not the plugin-dev name used in #157):

  • plugins/claude-code/plugin-utils/.claude-plugin/plugin.json — name plugin-utils
  • plugins/claude-code/plugin-utils/README.md
  • plugins/claude-code/plugin-utils/skills/data-storage-using-the-filesystem/SKILL.md + references/{storage-formats,streaming-formats,sync-and-concurrency}.md
  • Registers plugin-utils in .claude-plugin/marketplace.json (matching existing entry format)

The skill content is copied verbatim from #157; only the plugin name/wrapper changed.

Validation

  • mise run validate — all plugin manifests + marketplace validate successfully (including the new plugin-utils).
  • prettier --check (plugins workspace) — clean.
  • marketplace.json edit is a minimal additive block (existing entries untouched; not reformatted — the root/plugins lint does not prettier-check this file).

Notes

Co-Authored-By: Agent Alex Picard <alex-nsheaps[bot]@users.noreply.github.com>

…w plugin

Extracts the data-storage skill (file format selection, frontmatter
conventions, copy-swap concurrency, YAML→JSONL streaming boundaries,
known-path discipline, fetch-before-edit sync model) from PR #157 into a
new `plugin-utils` plugin rather than the pre-existing plugin-dev. Registers
plugin-utils in the marketplace manifest.

Co-Authored-By: Agent Alex Picard <alex-nsheaps[bot]@users.noreply.github.com>
@alex-nsheaps alex-nsheaps Bot added the request-review Force an AI code review on a draft PR (open non-draft PRs review automatically) label May 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Plugin Version Status

Versions are auto-bumped in PRs. Manual bumps to higher versions are preserved.

Plugin Base Current Action
plugin-utils 0.1.0 0.1.1 Auto-bumped

@henry-nsheaps henry-nsheaps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: feat(plugin-utils): extract data-storage skill into new plugin

Verdict: APPROVE — clean extraction, pure-additive, all CI green. Two P2 follow-up items noted below; neither blocks merge.


What I Reviewed

7 files, 1017 additions, 0 deletions. New plugins/claude-code/plugin-utils/ directory + marketplace.json registration. Verbatim skill content from PR #157, renamed plugin from plugin-devplugin-utils per Nate's direction.

CI

lint ✓ · build ✓ · test ✓ · auto-version-bump ✓


P2 — Markdown rendering defect in SKILL.md

File: plugins/claude-code/plugin-utils/skills/data-storage-using-the-filesystem/SKILL.md

In the YAML Cons section, the closing bold marker on one bullet is escaped instead of rendering:

- **JSONL conversion required** for RPC formats\*\* — ...

The \*\* at the end of formats\*\* renders as literal ** in GitHub markdown. The intended text is for RPC formats — with no trailing asterisks. Carry-forward from PR #157.

Fix: Change formats\*\*formats


P2 — SKILL.md version: frontmatter will drift permanently

File: plugins/claude-code/plugin-utils/skills/data-storage-using-the-filesystem/SKILL.md (frontmatter)

This SKILL.md has version: 0.1.0 in its frontmatter, but the auto-bump automation only updates plugin.json and marketplace.json. The plugin is now at 0.1.1 while SKILL.md still says 0.1.0. No other SKILL.md in this repo carries a version: field — this is a novel pattern that will be perpetually stale after every auto-bump.

Recommendation: Remove version: from the SKILL.md frontmatter to match the convention of all other skills in this repo. Track version only in plugin.json and marketplace.json where the auto-bump tooling can maintain it.


Positive notes

  • Plugin scaffold (plugin.json, README.md, marketplace entry) matches the task-utils reference implementation exactly. ✓
  • Marketplace entry is in correct alphabetical order between cron-utils and reddit. ✓
  • PR body clearly explains origin (#157), naming rationale, validation steps run. ✓
  • Commit messages follow conventional commits format with meaningful body. ✓
  • mise run validate pass confirmed in PR body. ✓

@nsheaps
nsheaps merged commit 228506b into main May 29, 2026
5 checks passed
@nsheaps
nsheaps deleted the claude/extract-plugin-utils-data-storage branch May 29, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request-review Force an AI code review on a draft PR (open non-draft PRs review automatically)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant