Re-sync dispatch-review.yaml to corrected canonical template #318
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -32,22 +32,22 @@ DRAFT — landing alongside implementation in PR #165 per the spec-with-impl dir | |||||
|
|
||||||
| ### Implementation map | ||||||
|
|
||||||
| | Section | File(s) | | ||||||
| | ----------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||||||
| | Topology — decider | [`.github/workflows/review-dispatch.yaml`](../../../../.github/workflows/review-dispatch.yaml) | | ||||||
| | Topology — receiver | [`.github/workflows/review-receiver.yaml`](../../../../.github/workflows/review-receiver.yaml) | | ||||||
| | Topology — consumer template | [`nsheaps/.github` — `ansible/templates/.github/workflows/dispatch-review.yaml`](https://github.com/nsheaps/.github/blob/main/ansible/templates/.github/workflows/dispatch-review.yaml) (sole source of truth; no mirror in this repo) | | ||||||
| | Topology — receiver template | [`templates/dispatch-receiver-review.yaml`](../../../../templates/dispatch-receiver-review.yaml) | | ||||||
| | Topology — plugin composite | [`../actions/run-agent/action.yaml`](../actions/run-agent/action.yaml) | | ||||||
| | Topology — review-code skill | [`../skills/review-code/SKILL.md`](../skills/review-code/SKILL.md) | | ||||||
|
Contributor
There was a problem hiding this comment. 🟡 nit · P2 · consistency The row above (
Suggested change
Non-blocking.1 Footnotes
|
||||||
| | Trigger events | `nsheaps/.github`'s `dispatch-review.yaml` template `on:` block | | ||||||
| | Check-run lifecycle (queued/dispatched/failure) | `review-dispatch.yaml` steps "Post queued check" → "Update check (dispatched\|dispatch failed)" | | ||||||
| | Check-run lifecycle (in_progress/terminal) | `review-receiver.yaml` steps "Update check (in_progress\|terminal\|agent failed)" | | ||||||
| | Approval dismissal | `review-receiver.yaml` step "Dismiss prior approval reviews" | | ||||||
| | Metrics emission (agent side) | `../skills/review-code/SKILL.md` step 11 | | ||||||
| | Metrics path export | `../actions/run-agent/action.yaml` step "Export trigger fields for prompt interpolation" | | ||||||
| | Metrics gate (receiver side) | `review-receiver.yaml` steps "Read agent metrics" + "Compute check conclusion" | | ||||||
| | `if: failure()` safety net | `review-receiver.yaml` step "Update check (agent failed)" + `review-dispatch.yaml` step "Update check (dispatch failed)" | | ||||||
|
|
||||||
| ## Problem | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 nit · P2 · readability
This is a single ~120-word sentence-tangle with three parentheticals and an em-dash chain, doing four separate jobs (where the template lives, path-layout note, membership pointer, why the local mirror is gone, and an aside about
pr-status-dispatch.yaml). Splitting into a short paragraph + bullets makes the operational info scannable and lets a reader who just wants "where's the template?" find it in one line:Non-blocking (docs already merged); worth folding into the next README pass.1
Footnotes
🟡 P2 — nit / polish. Non-blocking style/readability issue. ↩