-
Notifications
You must be signed in to change notification settings - Fork 0
Incremental PR review: skip/brief/full based on diff fingerprint #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nsheaps
wants to merge
11
commits into
main
Choose a base branch
from
claude/ai-mktpl-renovate-reviews-ztkti8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
286d91c
feat(review-utils): incremental review — skip/brief/full re-review de…
claude b8f3b19
Merge remote-tracking branch 'origin/main' into claude/ai-mktpl-renov…
claude 24d2137
chore: `mise run format`
nsheaps ab3c69b
Delete superseded dismiss-prior-approvals.sh; move rationale out of w…
claude 4170816
Merge remote-tracking branch 'origin/claude/ai-mktpl-renovate-reviews…
claude 54322f7
Merge remote-tracking branch 'origin/main' into claude/ai-mktpl-renov…
claude da2d4ad
Merge remote-tracking branch 'origin/main' into claude/ai-mktpl-renov…
claude 6af2981
Merge remote-tracking branch 'origin/main' into claude/ai-mktpl-renov…
claude 7aef704
Merge remote-tracking branch 'origin/main' into claude/ai-mktpl-renov…
claude 5df9da4
Merge remote-tracking branch 'origin/main' into claude/ai-mktpl-renov…
claude 0f20da2
Merge remote-tracking branch 'origin/main' into claude/ai-mktpl-renov…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
.github/scripts/review-receiver/dismiss-prior-approvals.sh
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where's the part that uses actions/cache to save information for PR reviews between runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not in
review-receiver.yaml— the cache restore/save lives in the composite action it calls,plugins/claude-code/review-utils/actions/run-agent/action.yaml(restore at lines 222-229, save at 332-337), since that's where${{ runner.temp }}/review-state.jsonis populated and where the agent run actually happens.review-receiver.yamljust invokesrun-agent— it doesn't touch the cache directly.Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it was already present? Can you trigger the review workflow through this PR and test that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No — verified via
git show main:.../run-agent/action.yaml | grep actions/cache, which returns nothing. The cache restore/save is new in this PR.Can't easily test it live through this PR though: this repo's own
.github/workflows/dispatch-review.yaml(the consumer template copy) calls the reusable decider viauses: nsheaps/agents/.github/workflows/review-dispatch.yaml@9384e01d...— a pinned commit SHA, not@mainand not this branch. Reusableworkflow_callworkflows always execute the code at the ref inuses:, so triggering a review on this PR right now would run that pinned SHA's code (which predates even currentmain, let alone this branch) — not the cache logic added here. Also this PR is a draft, so the gate wouldn't even fire without therequest-reviewlabel per itsif:condition.Real options to validate before merge:
review-utils(dogfooding via this repo's own future PRs).dispatch-review.yamlto this branch's HEAD, label this PRrequest-reviewto force the gate despite draft state, watch it run, then revert the pin before merge. Invasive but does exercise the real code path.I'd lean toward (1) unless you want the smoke test now — let me know which you'd prefer.
Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can ignore this, this session will solve that: https://claude.ai/code/session_01HfFLavgfxQetUjPgy1VYFR