Fix sync-plugin-specs workflow self-triggering with no plugins/ - #120
Merged
Merged
Conversation
This repo has no plugins/ directory (it hosts reusable actions, not plugins), but the workflow carried push/schedule/workflow_dispatch triggers in addition to workflow_call, causing it to fire directly against this repo and fail at `cd plugins` in sync.sh. Remove the direct triggers so this file is purely a reusable workflow, invoked only via workflow_call by consumer repos (ai-mktpl, agents) that actually have a plugins/ directory.
nsheaps
marked this pull request as ready for review
August 12, 2026 03:06
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Run 31361763759 — the
sync-specsjob in.github/workflows/sync-plugin-specs.yamlfailed:Why
nsheaps/github-actionsis a repo of reusable GitHub Actions/workflows — it has noplugins/directory (confirmed: repo root contains.claude,.github,.mise,pages, etc., noplugins/).This workflow file is meant to be a reusable workflow (
workflow_call) invoked by consumer repos that do have aplugins/directory —nsheaps/ai-mktplandnsheaps/agentsboth have their own copy of this file (synced from thensheaps/.githubansible template) that calls it via:However, this repo's copy of the workflow also carried its own
push,schedule(0 6 * * 1), andworkflow_dispatchtriggers in addition toworkflow_call. Those direct triggers cause the workflow to fire againstnsheaps/github-actionsitself every Monday (and on manual dispatch), checking out this repo — which has noplugins/dir — and failing atsync.sh'scd "$PLUGINS_DIR".Fix
Remove the
push,schedule, andworkflow_dispatchtriggers fromon:, leaving onlyworkflow_call. This restores the file to a pure reusable-workflow definition, callable only by consumer repos that actually have aplugins/directory to sync — matching howai-mktplandagentsalready invoke it.No changes to
sync.shor the composite action itself — this repo should never run the sync directly on its own tree.Test plan
sync.sh/composite action)ai-mktpl/agentsworkflow_call invocations are unaffected (they call by SHA/ref, not by trigger type)Generated by Claude Code