fix: correct typos and reference errors causing runtime failures#40
Open
yzcj105 wants to merge 1 commit intonshen:mainfrom
Open
fix: correct typos and reference errors causing runtime failures#40yzcj105 wants to merge 1 commit intonshen:mainfrom
yzcj105 wants to merge 1 commit intonshen:mainfrom
Conversation
- Fix typo in isMAC(): "maxunic" -> "macunix" - Fix isLinux(): remove incorrect self parameter, use global functions - Fix nvim-tree keymaps: add missing "keys." prefix for copy_absolute_path and toggle_file_info - Fix fix-yank require path: "utils.fix-yank" -> "insis.utils.fix-yank" Fixes nshen#39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 4 bugs that cause runtime errors or incorrect behavior:
isMAC():"maxunic"→"macunix"(was always returning false on macOS)isLinux()function: Remove incorrectselfparameter and use proper global function referenceskeys.prefix forcopy_absolute_pathandtoggle_file_info"utils.fix-yank"→"insis.utils.fix-yank"Fixes #39
Test Plan
All bugs were verified with Neovim v0.11.6:
isMAC() typo:
isLinux() error:
nvim-tree keymaps:
gyandghkeymaps now work in nvim-treefix-yank require: