Open
Conversation
I really want to label my chips beyond the reference designator.
|
Hello, I'm studying this repository and its pull requests and issues, looking for ways fellow students and I could contribute. Does more need to be done in this pull request? Is it ready to be merged, or is it going to be closed? |
Contributor
Author
|
This was/is work in progress. My disclaimer was that I'm not too familiar with the codebase or the code conventions of the language. It might be horrible work. It just does what I needed. I would be very supportive if this was useful to anyone else and they would polish it some more (if they're really eager if I never get around to it myself). Edit: hmm, nvm, I guess this was just a simple change. I was thinking the bigger work I had in my repo. |
paulgeorge
pushed a commit
to paulgeorge/netlistsvg
that referenced
this pull request
Mar 16, 2026
Cherry-pick of upstream PR nturley#75. Adds a value label below the reference label on the generic analog component template.
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really want to label my chips beyond the reference designator.
Note (which should prevent merging this as is perhaps): If the value is empty now, you'll get this blank space. Making the spacing dynamic (either moving the reference designator up (preferred) or putting the value under the chip) is probably more complicated.