fix discovery collector result metadata - #140
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances the discovery executor to report collector exit codes, output truncation status, and output limit bytes, updating the documentation and adding corresponding tests. The feedback suggests sanitizing cfg.maxOutputBytes to prevent a potential slice bounds out of range panic if configured with a negative value, and offers a refactoring suggestion to simplify the exit code extraction logic for better readability.
PrashantBtkl
marked this pull request as ready for review
August 17, 2026 05:25
PrashantBtkl
force-pushed
the
agent/collector-result-metadata
branch
from
August 17, 2026 05:33
3b48a9c to
e3b2cab
Compare
mayankpande88
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Discovery inventory results now expose trustworthy per-collector execution metadata while preserving the existing collector output wire format.
Why
Collector exit status was discarded, forcing packs to append fragile
echo "rc=$?"workarounds. Output truncation was also silent, making incomplete package inventories look authoritative.Fixes #137
Fixes #138
Validation
GOCACHE=/tmp/forager-go-cache go test ./...