Skip to content

chore(chart): add values.schema.json to catch typo'd/unknown top-level keys #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VanshikaR7 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(chart): add values.schema.json to catch typo'd/unknown top-level keys #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e2c8a
chore(chart): add values.schema.json to catch typo'd/unknown top-leve…
claude Jul 4, 2026
44818f4
chore: update image tags for main release
github-actions[bot] Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions charts/nudgebee-agent/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"$schema": "https://json-schema.org/draft-07/schema#",
"title": "nudgebee-agent",
"description": "Top-level values accepted by the nudgebee-agent chart. Rejects unknown top-level keys (e.g. typos, or keys copied from unrelated charts/docs) so a misconfigured value fails at `helm install`/`upgrade` time instead of silently no-oping.",
"type": "object",
"properties": {
"nameOverride": { "type": "string" },
"fullnameOverride": { "type": "string" },
"enablePrometheusStack": { "type": "boolean" },
"automountServiceAccountToken": { "type": "boolean" },
"globalConfig": { "type": "object" },
"enableServiceMonitors": { "type": "boolean" },
"kubewatch": { "type": "object" },
"runnerServiceAccount": { "type": "object" },
"runner": { "type": "object" },
"nodeAgent": { "type": "object" },
"opencost": { "type": "object" },
"rsa": { "type": ["object", "null"] },
"openshift": { "type": "object" },
"opentelemetry-collector": { "type": "object" },
"clickhouse": { "type": "object" },
"alertmanager": { "type": "object" }
Comment on lines +21 to +22

@gemini-code-assist gemini-code-assist Bot Jul 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since additionalProperties: false is set, any top-level keys not explicitly defined in this schema will cause validation to fail. Helm reserves the global key for passing values to all charts (including subcharts like clickhouse or opentelemetry-collector, which often rely on global for shared settings like image registries or pull secrets).

To prevent validation failures when users specify global values, please add the global key to the schema properties.

    "clickhouse": { "type": "object" },
    "alertmanager": { "type": "object" },
    "global": { "type": "object" }

},
"additionalProperties": false
}
2 changes: 1 addition & 1 deletion charts/nudgebee-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ runnerServiceAccount:
runner:
image:
repository: ghcr.io/nudgebee/nudgebee-agent
tag: 2026-07-04T08-07-20_16e73b6bee276ad9e112b06f69d8a88f91e52ec1
tag: 2026-07-04T11-16-26_e1730394cb5e420b38fb79351f2a23ab46490ede
# Image template the pod_profiler action launches debugger pods from.
# The agent substitutes `{}` for the variant (bpf, jvm, python, perf, ruby).
# Surfaces as PROFILER_IMAGE; leave empty to fall back to the binary default.
Expand Down
Loading