fix(runner/chronosphere): honor CHRONOSPHERE_TRACES_URL on the query path - #530
Open
mayankpande88 wants to merge 3 commits into
Open
fix(runner/chronosphere): honor CHRONOSPHERE_TRACES_URL on the query path#530mayankpande88 wants to merge 3 commits into
mayankpande88 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for overriding the Chronosphere traces search endpoint via the CHRONOSPHERE_TRACES_URL environment variable. The agent now registers the Chronosphere proxy if either the base URL or the explicit traces URL override is set. Feedback suggests updating the error message in QueryTraces to accurately reflect when neither URL is configured.
Contributor
|
📦 Image Tags Updated |
RamanKharchee
previously approved these changes
Jul 15, 2026
mayankpande88
force-pushed
the
fix/runner-chronosphere-traces-url
branch
2 times, most recently
from
July 15, 2026 09:42
2d20cb3 to
50de22e
Compare
…path The chronosphere_query_traces handler always posted to BaseURL + /api/v1/data/traces, ignoring CHRONOSPHERE_TRACES_URL — which the legacy chronosphere_client used verbatim as the traces search endpoint. CHRONOSPHERE_TRACES_URL was only read for the telemetry heartbeat, so a deployment relying on that override hit the wrong path. Add a TracesURL field on the client (fed from CHRONOSPHERE_TRACES_URL): use it verbatim when set, else fall back to the composed BaseURL path. Also enable the handler when either CHRONOSPHERE_URL or CHRONOSPHERE_TRACES_URL is set, so a traces-URL-only config still registers the action. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L2HAXQH1gEtX7h4sUJsi9j (cherry picked from commit 50de22e)
mayankpande88
force-pushed
the
fix/runner-chronosphere-traces-url
branch
from
August 11, 2026 09:50
50de22e to
5e3cc33
Compare
Contributor
Author
|
Rebased onto main: merged the TracesURL override into the retry/concurrency-limited client that landed on main since approval ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chronosphere_query_traces handler always posted to
BaseURL + /api/v1/data/traces, ignoring CHRONOSPHERE_TRACES_URL — which
the legacy chronosphere_client used verbatim as the traces search
endpoint. CHRONOSPHERE_TRACES_URL was only read for the telemetry
heartbeat, so a deployment relying on that override hit the wrong path.
Add a TracesURL field on the client (fed from CHRONOSPHERE_TRACES_URL):
use it verbatim when set, else fall back to the composed BaseURL path.
Also enable the handler when either CHRONOSPHERE_URL or
CHRONOSPHERE_TRACES_URL is set, so a traces-URL-only config still
registers the action.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01L2HAXQH1gEtX7h4sUJsi9j