fix(nubi): support --format json machine-readable output in single query mode - #109
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces JSON output formatting support to the nubi command, allowing users to retrieve structured execution details, and adds a corresponding unit test. The review feedback suggests enhancing this feature by ensuring all execution errors are returned in JSON format, parsing the raw usage metrics string into a structured nested JSON object for better machine readability, and adding corresponding test assertions to verify the metrics structure.
…(messages, agents, tool calls) in --format json
RamanKharchee
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for machine-readable JSON output (
--format json) when executingnbctl nubiin single-query mode (both synchronous and asynchronous).Changes
--format jsonis specified with-q/--query:--async) and context cancellation.TestNubiCmd_SyncQuery_JSONunit test incmd/nubi_test.goverifying JSON payload parsing and key assertions.Verification
golangci-lint run ./...: 0 issuesgo test ./...: 100% pass