Skip to content

docs: add CONTRIBUTING.md and SECURITY.md - #149

Merged
mayankpande88 merged 2 commits into
mainfrom
docs/contributing-security
May 12, 2026
Merged

docs: add CONTRIBUTING.md and SECURITY.md#149
mayankpande88 merged 2 commits into
mainfrom
docs/contributing-security

Conversation

@mayankpande88

Copy link
Copy Markdown
Contributor

Description

Adds two community-health files required before flipping the repo to public:

  • CONTRIBUTING.md — directs contributors based on whether the issue is upstream (FairwindsOps/nova) or fork-specific. Documents the mainprod branch model, local validation commands (matching what CI runs), conventional-commit style, PR expectations, and license/grant note.
  • SECURITY.md — establishes private vulnerability reporting via GitHub's Security tab as the primary channel and security@nudgebee.com as a fallback. States scope (this repo only — upstream goes to Fairwinds), expected response timelines (3-day ack, 10-day initial assessment), and that only the latest prod tag is patched.

Review Notes — Risks & Counterarguments

  • security@nudgebee.com is named but not verified to exist in this PR — if that address isn't actually monitored, the SECURITY.md should be updated before going public, or that line removed in favor of GitHub PVR only.
  • GitHub Private Vulnerability Reporting must be enabled in repo settings (Security → Reporting → enable) for the primary path in SECURITY.md to work. Settings → Code security → Private vulnerability reporting.
  • Supported-versions policy says "latest prod tag" — there is currently no tagged release. The first release should be cut before this policy is meaningful.
  • Branch model in CONTRIBUTING documents main → prod as the actual flow. Direct pushes to main and prod are stated as not accepted; branch protection currently allows force pushes on main — that's a separate fix (worth doing before going public).

How Has This Been Tested?

  • Both files render correctly as markdown.
  • Cross-references (README.md, NOTICE, LICENSE, .github/pull_request_template.md, .github/ISSUE_TEMPLATE/, .github/workflows/ci.yaml) all point to files that exist on main.

Two standard community-health files needed before flipping the
repository to public:

  - CONTRIBUTING.md: where to file what (upstream vs fork), branch
    model, local validation commands, commit style, PR expectations.
  - SECURITY.md: private vulnerability reporting via GitHub Security
    tab as primary channel, security@nudgebee.com as fallback, scope
    + supported-versions policy.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces CONTRIBUTING.md and SECURITY.md files to establish contribution guidelines and security reporting procedures for the repository. The reviewer identified a versioning typo for golangci-lint in the contribution guide and recommended removing the security email address if it is not yet monitored to ensure vulnerability reports are not missed.

Comment thread CONTRIBUTING.md
Comment thread SECURITY.md
Removes the 'main → prod' branch model from CONTRIBUTING.md and the
'latest tag on prod branch' wording from SECURITY.md. Repo is moving
to single-branch with releases cut as semver tags on main rather
than promotions to a long-lived prod branch.
@mayankpande88
mayankpande88 merged commit 120d725 into main May 12, 2026
1 check passed
@mayankpande88
mayankpande88 deleted the docs/contributing-security branch May 12, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants