ci: consolidate image-build workflow for single-branch model - #150
Merged
Conversation
Merges build-image-dev.yaml and build-image-prod.yaml into a single
build-image.yaml. With prod gone, the dev-/prod- tag prefixes lose
meaning.
Tag scheme:
push: main (or workflow_dispatch)
→ ghcr.io/nudgebee/nova:<timestamp>_<git-sha>
push: tags v*
→ ghcr.io/nudgebee/nova:<git-tag> (e.g. v0.1.0)
The prod-branch trigger is removed; releases are cut as semver tags
on main rather than promotions to a long-lived prod branch.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
RamanKharchee
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the two image-build workflows for the single-branch model. With
prodgoing away, thedev-/prod-tag prefixes from #148 lose meaning, andbuild-image-prod.yaml'spush: prodtrigger never fires.Changes
.github/workflows/build-image-prod.yaml..github/workflows/build-image-dev.yaml→.github/workflows/build-image.yaml.dev-tag prefix.tags: ["v*"]trigger so semver tags published againstmainproduce a versioned image.New tag scheme
push: main(orworkflow_dispatch)ghcr.io/nudgebee/nova:<YYYY-MM-DDTHH-mm-ss>_<git-sha>push: tags v*(e.g.v0.1.0)ghcr.io/nudgebee/nova:v0.1.0The timestamp format is unchanged from previous workflows so consumers parsing it still work.
Review Notes — Risks & Counterarguments
dev-orprod-prefixed images will break. Search for the old tag prefixes in helm charts / ArgoCD manifests / deploy scripts before merging. Migration: drop the prefix.latest/maintag. Every image is uniquely tagged. If a consumer wants "latest commit on main", they'd need to resolve it themselves (or we can add a floating tag later viadocker/metadata-actionif there's demand).prodbranch is now orphaned: nothing in CI references it. Safe to delete on origin after this merges (separate cleanup, not part of this PR).workflow_dispatchfirst to verify nothing else regressed, then push av0.0.1or similar trial tag if you want to validate the release path before cuttingv0.1.0.How Has This Been Tested?
yqround-trip locally).workflow_dispatchfirst.