Skip to content

fix: give email more memory headroom after OOM - #465

Open
mayankpande88 wants to merge 2 commits into
mainfrom
demo/email-mem-increase
Open

fix: give email more memory headroom after OOM#465
mayankpande88 wants to merge 2 commits into
mainfrom
demo/email-mem-increase

Conversation

@mayankpande88

Copy link
Copy Markdown
Contributor

Email was OOM-killed recently; raising requests/limits 100Mi -> 128Mi.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the memory requests and limits for a component in the Kubernetes sample-app configuration from 100Mi to 128Mi. The review feedback correctly points out that this change conflicts with the design of the demo scenario, which relies on a lower memory limit to trigger an OOM-kill simulation. Increasing the limit could prevent the simulation from functioning as intended.

Comment on lines +307 to +310
memory: 128Mi
limits:
cpu: 100m
memory: 100Mi
memory: 128Mi

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Raising the memory limit to 128Mi conflicts with the design of the demo scenario described in the comments (lines 300-302), which states that the limit is kept modest to allow the OOM-kill simulation to trigger and generate metrics. Increasing the limit to 128Mi will significantly delay or entirely prevent the OOM-kill from occurring under standard demo traffic, rendering the simulation ineffective. If the recent OOM-kill was the result of the simulated leak, it represents expected behavior. If it occurred during steady-state, the underlying memory growth should be investigated or the simulation threshold adjusted, rather than increasing the limit and disabling the scenario.

@nudgebee-dev

nudgebee-dev Bot commented Aug 7, 2026

Copy link
Copy Markdown

Nudgebee Change Gate

Pass

  • email: Memory requests and limits increased from 100Mi to 128Mi. Sizing check was inconclusive as no recent recommendation data was found.

Based on Nudgebee rightsizing recommendations and incident investigations from the last 30 days.

View the gate agent investigation

@nudgebee nudgebee deleted a comment from nudgebee-dev Bot Aug 7, 2026
@github-actions

Copy link
Copy Markdown

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant