fix: give email more memory headroom after OOM - #465
Conversation
There was a problem hiding this comment.
Code Review
This pull request increases the memory requests and limits for a component in the Kubernetes sample-app configuration from 100Mi to 128Mi. The review feedback correctly points out that this change conflicts with the design of the demo scenario, which relies on a lower memory limit to trigger an OOM-kill simulation. Increasing the limit could prevent the simulation from functioning as intended.
| memory: 128Mi | ||
| limits: | ||
| cpu: 100m | ||
| memory: 100Mi | ||
| memory: 128Mi |
There was a problem hiding this comment.
Raising the memory limit to 128Mi conflicts with the design of the demo scenario described in the comments (lines 300-302), which states that the limit is kept modest to allow the OOM-kill simulation to trigger and generate metrics. Increasing the limit to 128Mi will significantly delay or entirely prevent the OOM-kill from occurring under standard demo traffic, rendering the simulation ineffective. If the recent OOM-kill was the result of the simulated leak, it represents expected behavior. If it occurred during steady-state, the underlying memory growth should be investigated or the simulation threshold adjusted, rather than increasing the limit and disabling the scenario.
Nudgebee Change GatePass
Based on Nudgebee rightsizing recommendations and incident investigations from the last 30 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Email was OOM-killed recently; raising requests/limits 100Mi -> 128Mi.