Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy General community board and introduces comments + one-level replies for both Anonymous posts and Topic posts, along with supporting DTO/docs/test updates to unify the community structure around Topics going forward.
Changes:
- Deleted the General board module (entities/services/controllers/tests/docs/frontend hooks).
- Added comment/reply entities, services, controllers, DTOs, and migration support for Anonymous + Topic posts.
- Added integration test harness and new integration specs; updated REST API docs and adjusted Jest config/dependencies.
Reviewed changes
Copilot reviewed 36 out of 39 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/users.e2e.spec.ts | Adds integration coverage for user lookup endpoint. |
| test/integration/topics.e2e.spec.ts | Adds integration coverage for topic CRUD endpoints. |
| test/integration/topic-posts.e2e.spec.ts | Adds integration coverage for topic post CRUD endpoints. |
| test/integration/topic-comments.e2e.spec.ts | Adds integration coverage for topic post comments + replies endpoints. |
| test/integration/anonymous-posts.e2e.spec.ts | Adds integration coverage for anonymous post CRUD endpoints. |
| test/integration/anonymous-comments.e2e.spec.ts | Adds integration coverage for anonymous comments + replies endpoints. |
| test/integration/health.e2e.spec.ts | Adds integration coverage for health endpoint. |
| test/integration/helpers/test-app.ts | Provides reusable Nest test app bootstrap + auth helpers for integration tests. |
| test/integration/testcontainers-env.ts | Ensures DB/Redis env via testcontainers when not externally provided. |
| src/modules/community/topic-posts/topic-post-comments.service.ts | Implements topic post comment/reply create/list/update/delete logic. |
| src/modules/community/topic-posts/topic-post-comments.service.spec.ts | Unit tests for topic post comments service behavior. |
| src/modules/community/topic-posts/topic-post-comments.controller.ts | Exposes topic post comment/reply REST endpoints. |
| src/modules/community/topic-posts/topic-post-comment.entity.ts | Adds TypeORM entity for topic post comments/replies. |
| src/modules/community/topic-posts/topic-post-comment.dto.ts | Adds Swagger DTOs for topic post comments/replies APIs. |
| src/modules/community/anonymous/anonymous-comments.service.ts | Implements anonymous comment/reply create/list/update/delete logic with password auth. |
| src/modules/community/anonymous/anonymous-comments.service.spec.ts | Unit tests for anonymous comments service behavior. |
| src/modules/community/anonymous/anonymous-comments.controller.ts | Exposes anonymous comment/reply REST endpoints. |
| src/modules/community/anonymous/anonymous-comment.entity.ts | Adds TypeORM entity for anonymous comments/replies. |
| src/modules/community/anonymous/anonymous-comment.dto.ts | Adds Swagger DTOs for anonymous comments/replies APIs. |
| src/modules/community/dto/posts.dto.ts | Introduces shared CommentContentDto validation/transform. |
| src/modules/community/dto/comment.dto.ts | Introduces shared base DTOs for comment list/reply list response shapes. |
| src/modules/community/community.module.ts | Wires in new comment entities/services/controllers and removes General board wiring. |
| src/migrations/1774222245483-Init.ts | Updates init schema: removes general_posts and adds topic_post_comments + anonymous_comments. |
| src/common/dto/pagination.dto.ts | Adds cursor-based pagination query/meta DTOs for replies. |
| package.json | Adds test deps (supertest/types) and npm overrides. |
| package-lock.json | Lockfile updates reflecting new deps/overrides. |
| jest.config.js | Lowers global coverage thresholds. |
| docs/RESTAPI/community-topic.md | Removes General section and adds Topic comments API documentation. |
| docs/RESTAPI/community-anonymous.md | New Anonymous module doc, including anonymous comments API documentation. |
| docs/RESTAPI/README.md | Splits community docs into community-anonymous and community-topic. |
| mvp-frontend/index.html | Removes General UI and adds comment/reply controls for anonymous/topic boards. |
| mvp-frontend/app.js | Removes General handlers and adds comment/reply API calls for anonymous/topic boards. |
| src/modules/community/general/general-posts.service.ts | Removes General board post service. |
| src/modules/community/general/general-posts.service.spec.ts | Removes General board post service tests. |
| src/modules/community/general/general-posts.controller.ts | Removes General board posts controller. |
| src/modules/community/general/general-posts.controller.spec.ts | Removes General board posts controller tests. |
| src/modules/community/general/general-post.entity.ts | Removes General board post entity. |
| src/modules/community/general/general-post.dto.ts | Removes General board post DTOs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/community/topic-posts/topic-post-comments.service.ts
Outdated
Show resolved
Hide resolved
src/modules/community/anonymous/anonymous-comments.service.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 39 out of 42 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/community/topic-posts/topic-post-comments.service.ts
Outdated
Show resolved
Hide resolved
src/modules/community/topic-posts/topic-post-comments.service.ts
Outdated
Show resolved
Hide resolved
src/modules/community/topic-posts/topic-post-comments.service.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
Good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/modules/community/general/*and removed related modules and routingThis allows administrators to later create a general board within Topics and unify the structure.
For more details, refer to the REST API Docs.