fix: wait for Caddy to be ready before restoring routes on startup #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worker was attempting to restore Caddy routes immediately on startup, before Caddy's admin API was available. This caused all route restoration to fail when both services started simultaneously. Added wait_for_caddy_ready() that polls the Caddy admin API every 500ms with a 60s timeout before attempting route restoration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wait_for_caddy_ready()function that polls Caddy admin API every 500msProblem
When both services start simultaneously (e.g., system boot), the worker would immediately try to restore routes but Caddy's admin API wasn't ready yet, resulting in:
Test plan