Skip to content

support/QtAwesome: Update to Font Awesome 7#129

Merged
nullobsi merged 1 commit into
nullobsi:mainfrom
tgurr:fontawesome-7
Feb 19, 2026
Merged

support/QtAwesome: Update to Font Awesome 7#129
nullobsi merged 1 commit into
nullobsi:mainfrom
tgurr:fontawesome-7

Conversation

@tgurr
Copy link
Copy Markdown
Contributor

@tgurr tgurr commented Jan 9, 2026

Update bundled copies to Font-Awesome release 7.2.0.

Related #35, #107, #114.

@nullobsi
Copy link
Copy Markdown
Owner

Thanks for the pull request. Have you checked if https://github.com/nullobsi/cantata/blob/main/support/QtAwesomeEnumGenerated.h needs to be updated? I believe upstream QtAwesome gamecreature/QtAwesome@e823065 has already made this upgrade and they regenerated the enum files, so that would need to be updated too.

@tgurr
Copy link
Copy Markdown
Contributor Author

tgurr commented Jan 10, 2026

Thanks for the pull request. Have you checked if https://github.com/nullobsi/cantata/blob/main/support/QtAwesomeEnumGenerated.h needs to be updated? I believe upstream QtAwesome gamecreature/QtAwesome@e823065 has already made this upgrade and they regenerated the enum files, so that would need to be updated too.

Thanks for the hint, additionally there's a QtAwesomeStringGenerated.h I've now updated as well. Upstream changed the formatting a bit, e.g. indent with spaces instead of tabs now but I've kept it like it was to have an easy readable diff. (I wonder if it would rather make sense to just update the bundled QtAwesome alltogether than picking single changes, but for now this works.)

@nullobsi
Copy link
Copy Markdown
Owner

There are some slight changes made in the bundled copy, but it hasn't deviated much. It seems the upstream changes are mostly to add support for new paid FontAwesome symbols which we don't use.

@tgurr
Copy link
Copy Markdown
Contributor Author

tgurr commented Feb 11, 2026

Updated the bundled fonts to https://github.com/FortAwesome/Font-Awesome/releases/tag/7.2.0

Update bundled copies to Font-Awesome release 7.2.0.

Related #35, #107, #114.
@nullobsi nullobsi merged commit 6ef6472 into nullobsi:main Feb 19, 2026
4 checks passed
@tgurr tgurr deleted the fontawesome-7 branch February 19, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants