Skip to content

feat(charts-base): delete hooks #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastiancorrea81 merged 1 commit into from
Feb 2, 2026
Merged

feat(charts-base): delete hooks #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions charts/base/templates/finalizer.yaml
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions charts/base/templates/gateways.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ metadata:
name: {{ .Values.namespaces.gateway }}
labels:
name: {{ .Values.namespaces.gateway }}
annotations:
"helm.sh/hook": pre-install, pre-upgrade
"helm.sh/resource-policy": "keep"
{{- end }}
---
{{- if and .Values.gateways.enabled .Values.gateway.internal.enabled }}
Expand Down Expand Up @@ -89,7 +86,6 @@ metadata:
{{- /* Default annotations for other providers */ -}}
service.beta.kubernetes.io/port_443_health-probe_protocol: "tcp"
{{- end }}
"helm.sh/resource-policy": "keep"
spec:
gatewayClassName: istio
{{- with .Values.gateway.internal.addresses }}
Expand Down Expand Up @@ -228,7 +224,6 @@ metadata:
{{- /* Default annotations for other providers */ -}}
service.beta.kubernetes.io/port_443_health-probe_protocol: "tcp"
{{- end }}
"helm.sh/resource-policy": "keep"
spec:
gatewayClassName: istio
{{- with .Values.gateway.public.addresses }}
Expand Down
3 changes: 0 additions & 3 deletions charts/base/templates/namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ metadata:
labels:
name: {{ .Values.namespaces.nullplatformTools }}
annotations:
"helm.sh/hook": pre-install, pre-upgrade
openshift.io/cluster-monitoring: "true"
{{- end }}
---
Expand All @@ -17,7 +16,5 @@ metadata:
name: {{ .Values.namespaces.nullplatformApplications }}
labels:
name: {{ .Values.namespaces.nullplatformApplications }}
annotations:
"helm.sh/hook": pre-install, pre-upgrade
{{- end }}
---