Skip to content

Conversation

@geisbruch
Copy link
Contributor

No description provided.

sebasnallar and others added 14 commits September 15, 2025 11:55
* [feature]: Added support for external DNS using dns endpoint

* [feature]: waiting on balancer recognition for route

* [chore]: rename dns type to 'external_dns' in mninus

* [chore]: revert values.yaml

* [chore]: get information from providers for gateways

* [chore]: rework, we now apply the dns ednpoint only on scope creation

* [chore]: rework, we now apply the dns ednpoint only on scope creation

* [chore]: pr review

* [feature] define a component name with maximum 63 characters based on namespace and application slug

* feat: log improvements (#58)

* [fixes][route53]: we create the record on both hosted zones

* [feature] ignore not found errors when deleting k8s objects

* [feature] set default memory to 128 MB

* [feature] Add missing labels to k8s objects + Allow to delete extra gPRC ports (#68)

* [feature] Add missing labels to k8s objects

* [feature] add script to delete all objects related to a deployment_id

* feat: add Pod Disruption Budget (PDB) support (#64)

* feat: add Pod Disruption Budget (PDB) support

- Add POD_DISRUPTION_BUDGET configuration to values.yaml
- Integrate PDB settings into deployment build_context using jq
- Create pdb.yaml.tpl template with standard annotations and labels
- Support for configurable maxUnavailable (percentage or number)

* [feature]: pod disruption budget build tpl

* [feature]: private and public domains (#65)

* [feature] add support for web sockets inbound traffic (#69)

---------

Co-authored-by: Sebastian Nallar <sebastiansaidnallar@gmail.com>
Co-authored-by: Sebastian Nallar <95891104+sebasnallar@users.noreply.github.com>
Co-authored-by: Javi <javier.solis@nullplatform.io>
* [fix] do not re-apply Job objects

* skip wait deployment active

* Merge pull request #77 from nullplatform/feat/add_file_params

feat: Add mount file parameters

* [logging] remove unnecessary logs (#78)

---------

Co-authored-by: Ignacio Boudgouste <73672747+ignacioboud@users.noreply.github.com>
This reverts commit dde9e65.
This reverts commit dde9e65.
@geisbruch geisbruch changed the title Improve logs Add troubleshooting dump script Dec 10, 2025
@geisbruch geisbruch changed the title Add troubleshooting dump script [feature] Add troubleshooting dump script Dec 10, 2025
@fedemaleh fedemaleh changed the base branch from main to beta December 10, 2025 14:01
Comment on lines +238 to +242
# Object naming patterns based on analysis
DEPLOYMENT_NAME="d-${SCOPE_ID}-${DEPLOYMENT_ID}"
SECRET_NAME="s-${SCOPE_ID}-d-${DEPLOYMENT_ID}"
HPA_NAME="hpa-d-${SCOPE_ID}-${DEPLOYMENT_ID}"
PDB_NAME="pdb-d-${SCOPE_ID}-${DEPLOYMENT_ID}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No conviene buscar por label? Se que al menos Itti metio un override para cambiar el nombre de los objetos.

if kubectl get events -n "${NAMESPACE}" \
--field-selector involvedObject.name="${resource_name}" \
--sort-by='.lastTimestamp' 2>/dev/null | grep -v "^No resources found"; then
:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que onda este :?

if kubectl get events -n "${NAMESPACE}" \
--field-selector involvedObject.name="${resource_name}" \
--sort-by='.lastTimestamp' 2>/dev/null | grep -v "^No resources found"; then
:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tendría sentido invertir la condición? Entiendo que estamos metiendo un noop acá.

if kubectl get events -n "${NAMESPACE}" \
--field-selector involvedObject.name="${resource_name}" \
--sort-by='.lastTimestamp' 2>/dev/null | grep -v "^No resources found"; then
:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tendría sentido invertir la condición? Entiendo que estamos metiendo un noop acá.

if kubectl get events -n "${NAMESPACE}" \
--field-selector involvedObject.name="${pod_name}",involvedObject.kind=Pod \
--sort-by='.lastTimestamp' 2>/dev/null | grep -v "^No resources found"; then
:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tendría sentido invertir la condición? Entiendo que estamos metiendo un noop acá.

if get_and_print_resources_by_label "pod"; then
# Get detailed pod status
print_section "Pod Status (detailed)"
kubectl get pods -n "${NAMESPACE}" -l "${LABEL_SELECTOR}" -o wide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estamos haciendo el kubectl get pods un montón de veces.

No tiene sentido hacer el get y dejarlo en una variable archivo y que el resto lo lea? @ignacioboud ya hizo esta lógica para el diagnose podríamos copiarla.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mi duda es como queremos utilizar esto por que veo un upload, podemos agregarle de ultima un parametro al diagnose par que haga el upload de la data cruda. me resulta raro que este en dos lugares diferentes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants