[feature]: previous logs #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rqbazan
reviewed
Sep 2, 2025
k8s/log/kube-logger-bash/exec
Outdated
| NEXT_PAGE_TOKEN="" | ||
| FILTER_PATTERN="" | ||
| START_TIME="" | ||
| PREVIOUS=true |
There was a problem hiding this comment.
Esto no deberia empezar en false?
Suggested change
| PREVIOUS=true | |
| PREVIOUS=false |
Contributor
Author
There was a problem hiding this comment.
El behaviour del plugin viejo de nullplatform (push mode scopes) siempre fue este y nunca se apaga
| OVERRIDES_WORKFLOW_PATH="$OVERRIDES_PATH/log/workflows/log.yaml" | ||
|
|
||
| CMD="np service workflow exec --no-output --workflow $WORKFLOW_PATH" | ||
| CMD="np service workflow exec --no-output --build-context --workflow $WORKFLOW_PATH" |
Contributor
Author
There was a problem hiding this comment.
Para poder tener contexto de los providres, en este caso estamos siempre defaulteando al namespace de 'nullplatform' lo cual es incorrecto, ya que el namespace donde estan los pods se define a traves de providres. Podriamos isno, quiza, buscar por labels sin importar el namespace pero bueno, habria que verlo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.