feat: add Azure DNS support to external_dns module #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Azure DNS as a new provider option with two authentication methods: 1. Azure Workload Identity (recommended for AKS) - Uses pod identity with federated credentials - Configures service account with workload identity labels/annotations 2. Service Principal - Uses client ID/secret via azure.json config file - Mounts credentials as volume at /etc/kubernetes/azure.json Changes: - Add Azure-specific variables (resource_group, tenant_id, subscription_id, client_id, client_secret, use_workload_identity) - Add azure_workload_identity_config and azure_service_principal_config - Add Kubernetes secret for Azure credentials (azure.json format) - Use null-safe ternary operators for provider-specific variables - Update README with Azure usage examples 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Following the Cloudflare pattern, pass azure_client_secret through locals.tf to the template so the helm chart receives it. This fixes Azure DNS authentication for cert-manager when using Service Principal credentials. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
julianklas
force-pushed
the
feature/extenral-dns-azure
branch
from
bc6a261 to
9e59af3
Compare
Collaborator
|
@julianklas The policy creation is missing; it should be in a folder like azure/dns_role. For example, in "oci", there is the dynamic groups folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
azure_resource_group,azure_tenant_id,azure_subscription_id,azure_client_id,azure_client_secret,azure_use_workload_identity)azure_workload_identity_configandazure_service_principal_configwith proper volume mountsTest plan
🤖 Generated with Claude Code