Skip to content

Update script file permissions - #132

Closed
tonythethompson wants to merge 2 commits into
masterfrom
chore
Closed

Update script file permissions#132
tonythethompson wants to merge 2 commits into
masterfrom
chore

Conversation

@tonythethompson

Copy link
Copy Markdown
Collaborator

Changed mode for bump-contract.sh, push-homebrew-tap.sh, and sign-sha256sums.py from executable (755) to regular (644).

tonythethompson and others added 2 commits August 20, 2026 03:06
Changed mode for bump-contract.sh, push-homebrew-tap.sh, and sign-sha256sums.py from executable (755) to regular (644).
@github-actions

Copy link
Copy Markdown
Contributor

New%20session%20-%202026-08-20T10%3A07%3A38.720Z
opencode session  |  github run

@tonythethompson

Copy link
Copy Markdown
Collaborator Author

/oc should this pr be closed?

@github-actions

Copy link
Copy Markdown
Contributor

Recommendation: close this PR

The mode flip (755 → 644) is a pure metadata change with no content delta, and it silently breaks a documented, load-bearing invocation path.

Evidence:

  1. scripts/bump-contract.sh is the sanctioned cross-repo roadmap-bump procedure, and it is documented to be invoked directly, not via an interpreter:

    • docs/contracts/roadmap-v1.md:121 and roadmap-v2.md:121: scripts/bump-contract.sh 2 -r "..." (also referenced in cross-repo-mirror/README.md).
    • Its own header comment (bump-contract.sh:24): # scripts/bump-contract.sh <NEW_VERSION> [-r "reason for the bump"].

    Direct path invocation requires the executable bit. After this PR, scripts/bump-contract.sh fails with Permission denied unless the maintainer knows to prefix bash.

  2. scripts/sign-sha256sums.py — no CI impact either way: release.yml:220 already invokes it as python3 "${GITHUB_WORKSPACE}/scripts/sign-sha256sums.py".

  3. scripts/push-homebrew-tap.sh — manual maintainer script, shebang'd, referenced nowhere; stripping +x gains nothing.

Counter-argument considered: repo consistency — release-notes-from-changelog.sh (644) and update-official-trust-root.sh (644) are run via bash. But those were always interpreter-invoked; bump-contract.sh is not. If consistency is the goal, the fix belongs in the docs/header (change to bash scripts/bump-contract.sh ...), not a silent mode flip.

Verdict: The PR provides no functional benefit, and it regresses the documented bump workflow with no rationale. Close it (or at minimum revert the bump-contract.sh mode change and update the docs to interpreter-style invocation if that's the intent).

New%20session%20-%202026-08-20T10%3A19%3A32.823Z
opencode session  |  github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant