-
Notifications
You must be signed in to change notification settings - Fork 4
Adding Sqlite #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding Sqlite #17
Conversation
|
currently I am renaming functions to as before[as made by leosartaj] and creating tests for them. Any suggestions? @leosartaj @sumitsahrawat |
|
Don't add [WIP] to the commits. Just the title of the PR. |
rollcall/sql/rollcallSQLClass.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any replacement to this line @leosartaj ? I used this line to import exce and func_json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Try this
from rollcall import exce, func_json
You should not play with path.
|
If you already have a function say |
|
Since we are not using json now, do I still use them? They are mixed up with json @leosartaj |
rollcall/sql/rollcallSQLClass.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subLIst is a list?
|
Please do not push any commits. I have not reviewed yet. Let @sumitsahrawat also pitch in. |
Added Gitter badge Renaming fileDelete->deleteSubject new.blah file deleted
[WIP]