Skip to content

Conversation

@0x6773
Copy link
Member

@0x6773 0x6773 commented May 14, 2015

[WIP]

@0x6773
Copy link
Member Author

0x6773 commented May 14, 2015

currently I am renaming functions to as before[as made by leosartaj] and creating tests for them. Any suggestions? @leosartaj @sumitsahrawat

@ghost
Copy link

ghost commented May 14, 2015

Don't add [WIP] to the commits. Just the title of the PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any replacement to this line @leosartaj ? I used this line to import exce and func_json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Try this

from rollcall import exce, func_json

You should not play with path.

@leosartaj
Copy link
Contributor

If you already have a function say full_path_to that does the job. Use it.

@0x6773
Copy link
Member Author

0x6773 commented May 14, 2015

Since we are not using json now, do I still use them? They are mixed up with json @leosartaj

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subLIst is a list?

@leosartaj
Copy link
Contributor

Please do not push any commits. I have not reviewed yet. Let @sumitsahrawat also pitch in.
Also for reviewing purposes and better understanding, I am opening an issue regarding using sql. It would be nice if you could describe the database structure there.

@leosartaj leosartaj mentioned this pull request May 14, 2015
@0x6773 0x6773 changed the title [WIP] Adding Sqlite Adding Sqlite May 17, 2015
0x6773 and others added 4 commits June 21, 2015 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants