Skip to content

Demonstrate CI rejection of provider reconnect regression - #1

Closed
numinousmuses wants to merge 1 commit into
masterfrom
forge/regression-proof
Closed

numinousmuses wants to merge 1 commit into
masterfrom
forge/regression-proof

Conversation

@numinousmuses

Copy link
Copy Markdown

This draft demonstrates Forge rejecting a real regression on our fork. It adds the issue Layr-Labs#747 regression tests without the fix. It is intentionally expected to fail and must not merge.

The isolated baseline run f1286ab874e40ea0d37c9c6130460b0d observed both required tests failing with exit code 1. The cases cover restoring statistics earned after coordinator startup and refusing state from another Secure Enclave key. This PR exercises the same failure through GitHub → AWS OIDC → Forge → fresh verification workers.

Before:

flowchart LR
    Reconnect[Provider reconnect] --> Restore[verifyProviderAttestation reads startup state]
    Restore --> Lost[Recent statistics lost or wrong identity restored]
Loading

After this test-only change:

flowchart LR
    Tests[Reconnect regression tests] --> Restore[Existing verifyProviderAttestation]
    Restore --> Failure[Assertions expose incorrect restore behavior]
    Failure --> CI[Forge blocks this PR]
Loading

The repair will be a separate, independently verified candidate. No upstream repository or production system is changed.

@numinousmuses

Copy link
Copy Markdown
Author

Numinous Forge · Change and verification

Result: verification failed as intended. Closed without merging. This PR deliberately adds regression tests without the reconnect fix so we can demonstrate rejection of broken behavior.

What the checks found:

  • Reputation earned after coordinator startup was not restored on reconnect.
  • State belonging to a different Secure Enclave signing key could be restored.

Protocol and documentation checks passed, but the coordinator regressions failed. Forge therefore reported failed verification; passing unrelated checks did not make the PR pass.

Next step: The actual repair and its passing verification are in PR #4. This test-only negative example should stay unmerged.

Review summary for 21ff4c6ae7a2. Live task and CI progress are reported separately.

@numinousmuses numinousmuses added the trigger:ci Forge was triggered by a contributor PR or new commit. label Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trigger:ci Forge was triggered by a contributor PR or new commit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant