Demonstrate CI rejection of provider reconnect regression - #1
Closed
numinousmuses wants to merge 1 commit into
Closed
numinousmuses wants to merge 1 commit into
numinousmuses wants to merge 1 commit into
Conversation
Author
Numinous Forge · Change and verificationResult: verification failed as intended. Closed without merging. This PR deliberately adds regression tests without the reconnect fix so we can demonstrate rejection of broken behavior. What the checks found:
Protocol and documentation checks passed, but the coordinator regressions failed. Forge therefore reported failed verification; passing unrelated checks did not make the PR pass. Next step: The actual repair and its passing verification are in PR #4. This test-only negative example should stay unmerged. Review summary for 21ff4c6ae7a2. Live task and CI progress are reported separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft demonstrates Forge rejecting a real regression on our fork. It adds the issue Layr-Labs#747 regression tests without the fix. It is intentionally expected to fail and must not merge.
The isolated baseline run
f1286ab874e40ea0d37c9c6130460b0dobserved both required tests failing with exit code 1. The cases cover restoring statistics earned after coordinator startup and refusing state from another Secure Enclave key. This PR exercises the same failure through GitHub → AWS OIDC → Forge → fresh verification workers.Before:
flowchart LR Reconnect[Provider reconnect] --> Restore[verifyProviderAttestation reads startup state] Restore --> Lost[Recent statistics lost or wrong identity restored]After this test-only change:
flowchart LR Tests[Reconnect regression tests] --> Restore[Existing verifyProviderAttestation] Restore --> Failure[Assertions expose incorrect restore behavior] Failure --> CI[Forge blocks this PR]The repair will be a separate, independently verified candidate. No upstream repository or production system is changed.