Skip to content

Avoid duplicate verification when a draft becomes ready - #3

Merged
numinousmuses merged 1 commit into
masterfrom
ci/avoid-ready-duplicate
Sep 5, 2026
Merged

numinousmuses merged 1 commit into
masterfrom
ci/avoid-ready-duplicate

Conversation

@numinousmuses

@numinousmuses numinousmuses commented Sep 5, 2026

Copy link
Copy Markdown

Opening a draft PR already starts Forge verification. Marking that same commit ready for review was starting a second full run with no code change. Remove that redundant trigger; opening, synchronizing, and reopening a PR still trigger verification.

This was observed on the prompted-work demo. The redundant queued run was cancelled before it allocated a Forge task.

Validation: regenerated the workflow from the platform template, reviewed the one-line diff, and ran all 14 bridge/workflow tests. This PR also passes through the fork's real Forge CI before merge.

Before:

flowchart LR
  D[Draft PR opened] --> O[forge-ci.yml opened event]
  O --> V1[run_ci.py submits Forge verification]
  R[Mark same draft ready] --> E[ready_for_review event]
  E --> V2[Duplicate verification of unchanged code]
Loading

After:

flowchart LR
  D[PR opened or updated] --> O[forge-ci.yml opened or synchronize event]
  O --> V[run_ci.py submits Forge verification]
  R[Mark unchanged draft ready] --> Keep[Existing verified status retained]
Loading

@numinousmuses
numinousmuses merged commit ab9e8aa into master Sep 5, 2026
2 checks passed
@numinousmuses numinousmuses added the trigger:ci Forge was triggered by a contributor PR or new commit. label Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trigger:ci Forge was triggered by a contributor PR or new commit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant